This repository was archived by the owner on Dec 21, 2021. It is now read-only.
Drop apikey support #195
Merged
Drop apikey support #195
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NET-43 Drop apiKey authentication method from JS client in 5.x
Requires major version bump, schedule for 5.0.0 if possible |
Contributor
|
@timoxley Endpoint has dynamic API Key to Integration Key conversion. PR title is slightly misleading. Devil's in the details :) |
timoxley
force-pushed
the
NET-43-drop-apikey-support
branch
from
fa89ae2 to
3dbfb4e
Compare
timoxley
force-pushed
the
NET-43-drop-apikey-support
branch
from
3dbfb4e to
f37bac5
Compare
hpihkala
approved these changes
Apr 16, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Like the username/password deprecation, this keeps support in the client going until
/login/apikey404s.Tests currently fail because unlike
/login/password,/login/apikeyseems to continue to exist in the docker e&e, despite streamr-dev/core-api#866 landing. Perhaps @kare or @teogeb know why/how.